Nick Pillitteri
Nick Pillitteri
Looking at the design of Slog a bit (very cool lib, BTW), it seems like writing metrics based on logging statements would be pretty unobtrusive. The only part of the...
Hey @dpc, I'm thinking about attempting to create a `Drain` implementation for Cadence in the next few weeks. Do you think this should be a crate that lives along side...
The separate repo sounds great, thanks.
Thanks! I'll try to take a first pass over this in a bit.
Before I take a more thorough look, I've come around to unconditionally including the dependency on `rand` since it would allow us to get rid of all the conditional compilation....
Unrelated to your changes, but make sure you're running tests and linting locally since it seems like I haven't correctly set CI to run for forks.
> I messed around with a slight refactor of this PR which tries a slightly different approach by moving the sampling behavior to a new type. LMK which you prefer:...
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase `main` and eventually move the CHANGELOG entry added / updated in this PR to the...
> @56quarters Paulin left a few comments on your changes. I will let you decide how you want to handle these I'll take a look and push some changes, thanks!
I've made a few of the changes and provided an explanation for others. Can the Alloy team take another look at this PR?