Nick Pillitteri

Results 92 comments of Nick Pillitteri

A while back we [switched the distributors](https://github.com/grafana/mimir/pull/2154) from using `ring.Lifecycler` to `ring.BasicLifecycler` so we could make use of the auto-forget functionality. This allows distributors to be removed from the ring...

I'll take a look at adding a filter method to the ring in dskit unless someone else has started already.

Support for Redis is planned and being worked on in https://github.com/grafana/dskit/pull/245. Is this issue for adding the ability to use Redis as a replacement for Memcached in Mimir as-is?

> From what I read in the [documentation](https://github.com/memcached/memcached/wiki/UserInternals#when-are-items-evicted), non expired items (an expiration time of 0 or some time in the future), are evicted when there's no memory available to...

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase `main` and eventually move the CHANGELOG entry added / updated in this PR to the...

Initial testing looks promising (the change is being tested in zone b in the following screenshots). Reduced allocations: ![Screenshot 2023-01-25 at 14-49-18 Explore - cortex-dev-01-dev-us-central-0 - Grafana](https://user-images.githubusercontent.com/1127373/214674018-95ce03cb-5588-4ef7-9500-0a789f593b25.png) Marginally less CPU...

I haven't included any tests for this change because the mock cache backend in combination with a mock allocator would have been more code than the change itself. I can...

Based on further testing I'm having doubts about this change. I'm going to add some additional instrumentation and see if I can tell what's causing the unexpected heap usage.

For posterity, after the change to create and free the `pool.SafeSlabPool` following the lifecycle of the `io.ReadCloser` returned by `CachedBucket` methods, the heap and RSS looks much more reasonable for...

Thanks for the PR! I've converted it to a draft until the upstream Thanos objstore PR is merged.