agent icon indicating copy to clipboard operation
agent copied to clipboard

Add integration usage to telemetry

Open RutgerKe opened this issue 3 years ago • 4 comments
trafficstars

Recently, in https://github.com/grafana/agent/issues/1488, some telemetry data was introduced.

I propose to leverage this feature to get a better grip on the usage of integrations in the agent. Which integrations are configured? How many metrics do they collect, how many logs? This could for example be an average over the currently used reporting-interval.

RutgerKe avatar Jun 27 '22 14:06 RutgerKe

This seems to be an increase in scope from the original intent of this feature:

this will help Agent team determine if a feature is getting enough traction to graduate from experimental/beta and what users are finding helpful/useful

I don't like the idea that more information could start being collected by the agent simply because someone at Grafana might find it useful. Do we document what information is collected anywhere? Is there any process or approval required to add something besides getting code merged?

56quarters avatar Jun 27 '22 14:06 56quarters

I don't like the idea that more information could start being collected by the agent simply because someone at Grafana might find it useful.

Could you elaborate on your concerns?

Do we document what information is collected anywhere? Is there any process or approval required to add something besides getting code merged?

Fair points, I don't know of any process right now, but agree that would be good. As part of this feature I think there should at least be clear documentation on what is collected. I'll let the agent maintainers comment further on this.

This seems to be an increase in scope from the original intent of this feature:

Why do you think this increases the scope? The integrations are part of the agent, and using them would be an indication that users find them 'helpful'.

RutgerKe avatar Jun 28 '22 12:06 RutgerKe

Personally, I'm comfortable adding more usage information as long as we:

  • Continue to document what we collect
  • Continue to document how to disable collection clearly in an obvious location
  • Clearly document when the things we collect changes between releases
  • Continue to only collect anonymous information

I do agree that integration usage info could be helpful in the same way that experimental feature usage info is helpful, and I think it's ok to broaden the scope as long as we're extremely transparent about doing it and why we're doing it.

rfratto avatar Jun 28 '22 17:06 rfratto

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity. Thank you for your contributions!

github-actions[bot] avatar Aug 21 '22 00:08 github-actions[bot]