Julian Verdurmen comments

Results 563 comments of


                                            Julian Verdurmen

Inconsistent code file encoding in this repo

So we missed that in a review, I see them in https://github.com/reqnroll/Reqnroll/pull/685 now. There is too bad not a Github App for this check.

[ScenarioDependencies] only called once per feature — breaks per-scenario test isolation

While we are working on https://github.com/orgs/reqnroll/discussions/472, a PR would be accepted. You could try using Copilot, if you test it yourself and review all the generated code :)

Reqnroll.SpecFlowCompatibility.Actions packages aren't compatible with Reqnroll 3

@gasparnagy FYI there are some other issues with that repo before we could move to reqnroll3 See https://github.com/reqnroll/Reqnroll.Actions/issues?q=is%3Aissue%20state%3Aopen%20label%3Abuild

#line directive contains only filename instead of relative path for subdirectory feature files

Are there any specs of the line directive in C#? I only found this, but it's missing the information about the paths. https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives#error-and-warning-information

#line directive contains only filename instead of relative path for subdirectory feature files

Closing this due to inactivity. Please let us know if this still an issue and please provide the requested info - thanks!

UTF-8 file is detected as Windows-1252 (western) (SBCSCodePageEncoding)

related https://github.com/CharsetDetector/UTF-unknown/issues/168

UTF-8 file is detected as Windows-1252 (western) (SBCSCodePageEncoding)

details tested it, 1252 is indead wrong

UTF-8 file is detected as Windows-1258 - Vietnamese (SBCSCodePageEncoding)

results currently: same results when using DetectFromBytes windows 1258 is indeed wrong, https://en.wikipedia.org/wiki/Windows-1258 - Vietnamese

exception with Nunit 4

Please post the full stacktrace and exception details, thanks!

exception with Nunit 4

Thanks!