Julian Verdurmen
Julian Verdurmen
reviewed. There is still an open discussion in this PR. I don't know the exact side effects of this change, so unfortunately I cannot approve this. @dtchepak maybe enable the...
See also https://github.com/microsoft/ApplicationInsights-dotnet/issues/2912, which is on the next milestone (2.23)
It think that the issue is in https://github.com/RicoSuter/NSwag/blob/512eb654b1be5714c7923b74d22e2049d56b5622/src/NSwag.CodeGeneration.TypeScript/Templates/Client.RequestBody.liquid#L54C1-L68C26 at it isn't checking `parameter.IsRequired` / `parameter.IsNullable`
So I'm a bit confused. SonarQube gives this warning in the GUI But the file does exists and the issue is nicely reported in SonarQube - so it does work....
That would be even better! Less dependencies is nice!
Not sure what "package provided" means here > .NET: Core 1.0, Core 1.1, Core 3.0, Core 3.1, 5, 6, 7, 8 (package-provided), 8, 9 (package-provided), 9, 10 (package-provided), 10 https://learn.microsoft.com/en-us/dotnet/api/system.text.codepagesencodingprovider?view=net-9.0
So for example with .NET 8 it's `8 (package-provided)` but also `8`. That's unclear to me! With a package reference, it supports less?
@ModernRonin polite bump :)
> Why was the decision made to change the default MaxDepth from null to 64? In short, security/DOS. See https://alephsecurity.com/vulns/aleph-2018004, https://github.com/JamesNK/Newtonsoft.Json/issues/2535 and https://github.com/JamesNK/Newtonsoft.Json/pull/2473 > Is it safe to explicitly set...
This issue could be resolved with the idea in #663