Julian Verdurmen

Results 563 comments of Julian Verdurmen

I think removing is a good choice, I have never heard that someone is using it.

Adding trimming support isn't trivial AFAIK. I'm tagging this as a feature request

Ah its documented somewhere else. Maybe explain in short that there are more attributes and can be found here: https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#package-validation-properties

It seems there are nullable changes in Caste Core we should handle here. See build errors. ``` Error: /home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/Proxies/CastleDynamicProxy/ProxyIdInterceptor.cs(28,29): error CS8602: Dereference of a possibly null reference. [/home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/NSubstitute.csproj::TargetFramework=net8.0] Error: /home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/Proxies/CastleDynamicProxy/CastleInvocationMapper.cs(12,13):...

Related https://github.com/nsubstitute/NSubstitute/issues/551

I propose for 6.0: - [ ] https://github.com/nsubstitute/NSubstitute/issues/868 (From #551)

Could we pin this issue? And/or create a 6.0 milestone?

> In fact, net8.0 is in my opinion also unneccessary to target directly, as netstandard2.0 contains: > > * .NET and .NET Core | 2.0, 2.1, 2.2, 3.0, 3.1, 5.0,...