Arseny Kapoulkine

Results 310 comments of Arseny Kapoulkine
trafficstars

Yeah I feel like in terms of allocation count, names are a much bigger problem. Whether we want to address it or not is unclear. cgltf doesn’t currently parse names...

That's what I ended up doing in user space for now: https://github.com/zeux/meshoptimizer/commit/91011f44c1b758412ca34f91b976ad887f10610b However, I don't think it's the full story really. Let's say we do that - do we force...

> How would it work in other scenarios? Does the user call the alloc function they passed into cgltf when modifying the extras data? So that cgltf_free() can freely free...

> const float* position_data = (float *)position_accessor->buffer_view->buffer->data; This ignores any type of offset that might apply to the accessor. I would recommend using cgltf_accessor_read_float or cgltf_accessor_unpack_floats helpers to read any...

One more small issue is that after installation, KTX-Software folder in Program Files has an executable file with an empty name (probably the uninstaller?) ![image](https://user-images.githubusercontent.com/1106629/86489522-7439d280-bd19-11ea-8298-0764ab274b0d.png)

> By the way, only ETC1S is affected by that for now. This should affect UASTC as well wrt mipmap generation presumably, even if the error metric used by the...

> Filtering for mipmap generation is done in linear space. Yes, which is controlled by `--linear` - or at least used to be controlled by that flag, presumably it's now...

Copying the comment from #524 on some future work involved here; the issue will stay open as the algorithm improves further: - The attribute metric is not perfect - it's...

Looking at this again, this is probably specific enough that glTF-Transform would be a better fit.