Arseny Kapoulkine

Should this be part of `PRIVATE` definitions? When I test this patch, I get the dependent modules to use the default visibility switch, but pugixml.cpp itself is built without it,...

I think we should stick to the current solution for now. It's not clear what the interaction between export headers and the existing pugiconfig would be (what if the users...

Can you elaborate on this? As in, is this a bug in clang-cl? Or is the compiler id selection not picking up MSVC-specific options for clang-cl? Do you have a...

I'm wondering if there's a way to specify the expression in such a way that it works for clang-cl as well; I don't recall the exact reasons but I know...

FWIW I'm impartial to the specific solution here, if a PR gets contributed to fix this I can merge it.

So this is somewhat intentional - the release archive is built for the most common use which includes compiling code and reading documentation but not building tests or fuzzing. However...

Additional note: for parsing unsigned integers, ERANGE will _not_ be set for negative numbers when using strtoul/strtoull - so we'll have to check whether there is a whitespace + minus...

New integer parsing implementation handles overflow/underflow correctly for all cases. It still uses the legacy way of clamping the result without indicating an error, but at least for integers it's...

Using UTF-8 instantly breaks compatibility with any CRT functions. For example, on Windows, in a portable program, you can do doc.load_file(argv[1]). And it would instantly fail for any file name...

> on Unixes it is the wrong thing to do Why? as_wide will work on Unixes as well. (of course, it's slightly less efficient than just passing the UTF-8 path...