Georg Semmler

Results 649 comments of Georg Semmler

I'm happy to accept a PR for this as long as it comes with documentation + tests.

This works as designed and closely mirrors the behaviour of other `QueryDsl` functions like `select`, `order_by` or `group_by`. Form that point of view it's more like `filter` is the exception...

I'm personally not a friend of exposing features from dependencies in such a way as it adds additional constraints on what you can/cannot change as crate without a major release....

@yutannihilation I'm not a maintainer here, but I personally would suggest to change the scope of the PR to add the relevant documentation instead. Maybe just a crate level documentation...

As already expressed to multiple parties: I'm aware of this PR and the problems with the CLA and I'm willing to spend some time figuring out how to resolve them...

> quick question, how do you think we should version gdal-src? Maybe 0.3.10? Because I think GDAL sometimes has breaking changes in minor bumps. Crates like [curl-sys](https://crates.io/crates/curl-sys) and [openssl-src](https://crates.io/crates/openssl-src) use...

Yes we are using gdal on windows. I personally would prefer to have prebuilt bindings for common platforms, which should include windows. I had a similar problem with the bindings...

So I gave this a try locally and the following chain of commands seem to work for me: ```sh sudo docker run -it --rm rust:1.82.0 bash # everything else is...

@lnicola I had another more detailed look at this and it turns out I get the same error if I use the osgeo containers and gdal >=3.9. In the end...