Georg Semmler

Results 636 comments of Georg Semmler

@wt This is still not addressed as we didn't implement any of this. We still look for someone to work at least on some of the points, possibly not the...

From diesel's point of view there are two `QueryDSL` methods broken here: `filter`/`find` and `left_join`/`inner_join`. At least for the `filter`/`find` methods there exists the following workaround: Instead of this: ```rust...

I think it might be fine to close this now given that the new trait solver has finally landed in rust-analyzer. With a "current" version of rust-analyzer (rust-analyzer 0.3.2675-standalone) I...

@mehcode This should be doable by using the methods provided by the [`Migration`](https://docs.rs/diesel_migrations/1.3.0/diesel_migrations/trait.Migration.html) in diesel-migrations.

@markus2330 We are happy to receive contributions for this. Otherwise there are many things that are desirable to have, but where nobody has the time or motivation to implement it.

Thanks for reporting. I agree that this is something that should be fixed. The relevant code for that is here: https://github.com/diesel-rs/diesel/blob/25cff1dcb6b24d144d2b39e8e03eb3d5582e9ea9/diesel_cli/src/main.rs#L149 We would appreciate a PR that fixes this issue...

Thanks for opening this PR. I'm sorry but I fear we won't be able to accept this PR as this is a breaking change as types from these crates appear...

> Doesn't this essentially mean that your public API (its part gated with "numeric") is currently unstable and may break when an unrelated crate in the consuming namespace is updated...

> In https://github.com/movementlabsxyz/aptos-core/issues/132 we were only able to fix this (in the short term) by downgrading bigdecimal to ^0.3, which is not desirable. I highly doubt that this is the...

@j-n-f We define several function instances for this. For the variant with no optional parameter we use the original name, for variants with optional parameter we chose a meaningful name...