Georg Semmler

Fixed as part of #22

Thanks for all your discussions here. Let me add a few arguments here: > Diesel uses many more (and more complex) generics than the median crate — in fact I'd...

Thanks for the pointers on how to extract these information. I'm out for holidays in the next weeks, but I can try to gather that information after I'm back.

As you already noticed: This depends on the order you call `.inner_join` and `.select`. Thats because the later function can only access type information provided up to this point. So...

Thanks for reporting this bug. It seems like that this impl is not general enough. Likely it must be change in such a way that it accepts all combinations of...

@mlesin What needs to be done is the following: * The linked impl needs to be changed to the following: ```rust impl ValidGrouping for AliasedField where S: AliasSource, C1: Column...

@zimmi That won't work this way because starting a transaction requires doing a call to the database. Once the control flow has entered the user provided closure there is no...

This is likely causes by https://github.com/diesel-rs/diesel/pull/3213. We would need an reproducible example for finding the exact cause for this issue, as the relevant PR is quite large.

Fixed by #3344

Thanks for the bug report. To clarify that: This was correct with the 1.4 release? Or was this always broken? The relevant impl is here: https://github.com/diesel-rs/diesel/blob/269e8b242eb2664c6fc98972de092a060d96be28/diesel/src/query_builder/upsert/on_conflict_clause.rs#L51-L66 The problematic field there...