Georg Semmler

Results 624 comments of Georg Semmler

Thanks for working on this. The `FromSql` implementation needs to read the binary representation of a json path as defined in the PostgreSQL protocol. Unfortunately the documentation of that format...

Thanks for putting the work in this PR. We cannot merge this as this is a breaking change. In addition as discussed in https://github.com/diesel-rs/diesel/issues/4649#issuecomment-2975151580 I would even consider the current...

@xuehaonan27 Sure that would be very welcome

Correct, that shouldn't have happened. (Github treats "Partially fixes #xyz" as command to close that issue 😞 )

@mertwole I do not have a plan for that ready yet. I would like to avoid generating many more instances for these cases, so maybe we can come up with...

@mertwole You are correct that won't work. Trait objects won't help there and using an enum is also not possible as this is an open set of types. You could...

@mertwole Let's try the macro variant, but with the following modifications: * Default to 2 variants * Check for an env-variable: `DIESEL_VARIADIC_FUNCTION_ARGS` and if that's set to a larger number...

For reference currently the following "breaking" changes are reported: ``` Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed...

> That's a good point about 3rd party backends. How would you recommend doing so, a trait implemented on the backend? Are there any existing examples of that? See the...

Thanks for opening this PR. I think we likely want to cover most of [these](https://github.com/search?q=repo%3Adiesel-rs%2Fdiesel+%22for+Box%3C%22&type=code) impls as well. (All but that one for `Instrumentation`)