Vladimir Sitnikov
Vladimir Sitnikov
>My point was that a List implementation can be quite complicated with iterators, spliterators, sublists, removes, etc I perfectly get that. >This class is quite simple because it only needs...
Here's what I have with `ParseStatement.bindExecuteFetch` benchmark (see https://github.com/pgjdbc/benchmarks/blob/436694736a342d39864704c5e892f9b237e0dd4f/src/main/java/org/postgresql/benchmark/statement/ParseStatement.java#L95 ): Note that `±Error` is quite high for response times, thus only allocation difference is actually significant here (Java 1.8u152, PostgreSQL...
As we are on Java 8+, should we consider using `java.util.stream.IntStream#builder()` instead of coding our own int-optimized `int array builder`?
Ah, it seems that IntStream#builder().add().stream().toIntArray() would incur significant overhead :-(
Technically speaking, we expect that all "public api" for a statement is exposed via `PGStatement`, and methods on `PgConnection` are non-public. I see no harm in exposing the sub-second timeout,...
@bokken , do you have opinions on `setQueryTimeoutMs(long)` vs `setQueryTimeout(Duration)` vs `setQueryTimeout(long value, TimeUnit timeUnit)`?
@svorcmar , we prefer "primary" rather than "master" wording. It is fine if you make it recognize both `preferPrimary` and `preferMaster`, however we would prefer to document just `preferPrimary`. Could...
Other than property naming the PR looks good to me.
Any thoughts, @chewiebug ?
> you know, that you can turn off, what you don't need to see in the "view" menu?) Of course I do. None of the current options cover "memory leak...