Vladimir Sitnikov
Vladimir Sitnikov
Could you add a test case?
>It's even posible that a "bool" (or any other) colummn type change to something else based on the wire format? I've no idea on the top of my head, however...
>As far as semver goes, it seems that there is a notion that because you have semver it's somehow OK to just break the contract with your users Exactly. I...
@bpd0018 , there might easily be `PGProperty.PROTOCOL_VERSION.set(properties, 3)` usages in the wild, so we cannot just remove `PROTOCOL_VERSION` property.
That is I would prefer to just document the current state of `protocolVersion` (== only `3` is supported, etc) and live it as is.
I expect the majority of the cases would be plain old usages that do not require retrieval of parameters. Thus it looks we should favor an implementation that decodes parameter...
Just in case, the test is locale-dependent. That is not good. `до н.э.` is a Russian for `BC` ``` org.junit.ComparisonFailure: LocalDateTime=-1996-06-30T23:59:59.999999, with TimeZone.default=Z, setObject(int, Object) Expected :1997-06-30 23:59:59.999999 до н.э....
@kdubb , technically speaking, the test was disturbed in https://github.com/pgjdbc/pgjdbc/pull/1388/files#diff-8b723c347b2146e27df7b1aa5f76e800L317 As far as I understand, when using ISO, PostgreSQL never prints locale-dependent BC.
Re this one: https://travis-ci.org/pgjdbc/pgjdbc/jobs/482125785#L1090-L1094 ``` testSetLocalDateTime[binary = FORCE](org.postgresql.test.jdbc42.SetObject310Test) Time elapsed: 0.546 sec
Unfortunately, I do not understand the nature of the issue yet. I would review this sometime later. The old behavior was there for quite some time, so users might already...