Vladimir Sitnikov

Results 1003 comments of Vladimir Sitnikov

Public extensions API is `org.postgresql.PGConnection`: https://github.com/pgjdbc/pgjdbc/blob/08631ccdabdb8ba6d52f398e2b0b46a9cf0cafbf/pgjdbc/src/main/java/org/postgresql/PGConnection.java#L21 `PGConnection` does not provide `getQueryExecutor`, so `QueryExecutor` interface is internal-to-driver.

There's `CallableStatement#setInt(String, int)` method: https://docs.oracle.com/javase/8/docs/api/java/sql/CallableStatement.html#setInt-java.lang.String-int- However, named parameters are specified only for `CallableStatement`, and I don't know what should be the syntax.

This sounds like a wrong level of abstraction to me. I do not understand what do you want to achieve

QueryExecutor is driver-private class, and I do not understand what are you going to achieve

>But I also see that it might benefit the user, if geometries are parsed from the byte data and not converted to a string and parsed back as byte data....

Sorry it takes so long to review. I think the approach with `PGBinaryObject` makes sense, however, I would like to refrain from using "driver-private APIs" (`PgConnection`, `QueryExecutor`) @sebasbaumh , would...

It looks like we need to parse procedure body as well (we could treat begin-end pairs as quote start and quote end)

1) +1 to @davecramer 2) Even though this looks like an improvement, I would assume it would be hard to notice/measure. Do you have numbers to compare? 3) The PR...

> I am not certain how to get the memory allocation data out of JMH `-prof gc`

>It is not an actual List implementation. It only implements a very few methods and is really quite simple Well, the reality with pgjdbc development is there's a lot of...