Vladimir Sitnikov
Vladimir Sitnikov
@kdubb , sorry it took so long to appreciate the request. ---- I think we should reconsider this change. The thing is that `LocalDate` and `LocalDateTime` classes provide exact meaning...
@lynnlovemin would you please update the PR?
@Sanne , is there an automated way to tell that the change did help SubstrateVM? Could GraalVM be added as a Travis job so we can know when the integration...
The way to go is https://www.sigstore.dev/ , however, its integration with Central is WIP. See https://central.sonatype.org/news/20220310_sigstore/
Thanks for adding some tests 👍 I see that the failure looks like ``` FAILURE 0.0sec, org.postgresql.core.ParserTest > testModifyJdbcCall java.lang.AssertionError: expected: but was: at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:120) at...
@benbenw , please add the test into a suite. pgjdbc's runs "tests sutes" only: https://github.com/pgjdbc/pgjdbc-parent-poms/blob/master/pgjdbc-versions/pom.xml#L189-L195 #890 had not been implemented yet
Could you clarify what do you mean by "The coverage is not great"? It is a bit hard to tell which tests are improved with this PR.
>The query parsing / transformation in CachedQueryCreateAction#create. Technically speaking, it has been covered via end-to-end tests. The test you add do not call #create directly.
I fully agree with you that QueryExecutor is not testable very well. To make QueryExecutor more testable might require some refactoring. I don't consider current `createQueryByKey` design a great one....
@benbenw , please check this out: https://github.com/pgjdbc/pgjdbc/blob/08631ccdabdb8ba6d52f398e2b0b46a9cf0cafbf/pgjdbc/src/main/java/org/postgresql/core/BaseConnection.java#L19