Vincent Batts

Results 240 comments of Vincent Batts

with #558 merged is this issue resolved? On Tue, Sep 13, 2016 at 11:15 AM W. Trevor King [email protected] wrote: > On Tue, Sep 13, 2016 at 07:54:58AM -0700, Ian...

like tianon said. Your explination seems fine, and maybe ought to be included in the text. Can https://github.com/microsoft/hcsshim/tree/master/internal/jobcontainers (or a versioned ref) be a decent perma-link for more info to...

looking at the git history, it seems there was a merge done instead of rebase, and now there is a bubble with #919 in it.

during discussion on the call, this has enough features and fields that it merits a point release, but not a major version change.

hmm yes. there's been about 26 PRs merged since 1.0.1 Looking through those changes, nothing particularly jumps out as being a breaking change. Thoughts?

@cyphar what are the requirements on hooks, and howcome it'll require a larger version bump?

I'm for this, but it adds to the release process, which I had to make a [checklist](https://github.com/opencontainers/runtime-spec/blob/main/RELEASES.md#checklist) for. It seems some of this can be done in phases, right? Like,...

ah yeah, we went back and forth on this. There were reasons that a `*string` was not desirable, but it would take @wking notes to dig that up :grimacing: I...

whoa sorry (since October 😓 ) CODEOWNERS is being used to migrate off of pullapprove (and whatever), to use the built in github approval configuration