Version: request to add a new version tag for runc dependencies

[xiaochenshen]

Issue:

The latest version tag of runtime-spec is v1.0.1, which is tagged about one year ago:

$ git tag -l | grep v1.0
v1.0.0
v1.0.0-rc1
v1.0.0-rc2
v1.0.0-rc3
v1.0.0-rc4
v1.0.0-rc5
v1.0.0-rc6
v1.0.1

$ git show v1.0.1
tag v1.0.1
Tagger: Vincent Batts <[email protected]>
Date:   Tue Nov 7 18:24:55 2017 -0500

Version tag v1.0.1 is lack of dependencies of recent runc changes. For example: https://github.com/opencontainers/runc/pull/1632 depends on commit 5684b8af48c1ac3b1451fa499724e30e3c20a294 https://github.com/opencontainers/runc/pull/1919 depends on commit 1722abf79c2f8f2675f47367f827c6491472cf27

In runc verdor config file (https://github.com/opencontainers/runc/blob/master/vendor.conf), runc prefers to specify a version tag of runtime-spec rather than a commit ID. But now it is a commit ID because of the dependencies:

github.com/opencontainers/runtime-spec 5684b8af48c1ac3b1451fa499724e30e3c20a294

Proposal:

How about adding a new version tag (e.g., v1.0.2-rc1 or something) to a recent commit ID, which contains runtime-spec changes after v1.0.1 for runc dependencies? And then we could update runtime-spec version tag in runc vendor config file (https://github.com/opencontainers/runc/blob/master/vendor.conf) as:

github.com/opencontainers/runtime-spec v1.0.2-rc1

@crosbymichael @vishh @mrunalp @vbatts @dqminh @philips @tianon @hqhq Hi runtime-spec maintainers, Do you have any suggestions? Thank you!

[vbatts]

hmm yes. there's been about 26 PRs merged since 1.0.1 Looking through those changes, nothing particularly jumps out as being a breaking change. Thoughts?

[cyphar]

Actually, we need some changes for runc 1.0:

• A version field to the hook state JSON, so that users can differentiate between spec versions in hooks.
• More hooks to supplement the current need of NVIDIA hooks and how they're currently blocking us from making runc spec-compliant with regards to hooks.

To be clear, I don't mind doing a release, it's just that we would have to do one soon afterwards so we could use it in runc 1.0. But then I think this might have to be a 1.1 bump for the spec... This is going to be amazing fun.

[vbatts]

@cyphar what are the requirements on hooks, and howcome it'll require a larger version bump?

[cyphar]

We need to add additional fields (the version field) as well as additional hook points (either preconfig or precreate/postcreate). I believe this will require a 1.1 bump since it's a new set of features, but maybe I misunderstand how we're using semver.