runtime-tools icon indicating copy to clipboard operation
runtime-tools copied to clipboard

Published 20 hours ago • verified publisher icon opencontainers

:rotating_light: Overhaul CI steps

Open vbatts opened this issue 4 years ago • 3 comments

  • [x] remove travis (it is now defunct and blocking merges)
  • [x] switch to github actions
  • [ ] switch to Github CODEOWNERS
  • [x] remove pullapprove

vbatts avatar Sep 29 '21 09:09 vbatts

@vbatts items 1 and 2 are now done (#728)

Can you tell a bit more about item 3? I read https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners but I don't quite get the benefits of using CODEOWNERS.

I guess item 4 can be implemented now -- can you please do it?

kolyshkin avatar Oct 22 '21 02:10 kolyshkin

I have removed pullapprove integration, instead enabling master branch protection rules (two LGTMs from maintainers are required to merge a PR, no direct pushes are allowed, etc).

@vbatts can you please elaborate on CODEOWNERS? As per my older comment,

I read https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners but I don't quite get the benefits of using CODEOWNERS.

kolyshkin avatar Jan 04 '22 21:01 kolyshkin

whoa sorry (since October 😓 ) CODEOWNERS is being used to migrate off of pullapprove (and whatever), to use the built in github approval configuration

vbatts avatar Jan 05 '22 20:01 vbatts