Vincent Batts

Results 240 comments of Vincent Batts

aww dang. I your comment in an open tab for too long and lost track of follow-up. Thanks for opening a new thread. Funny, I just chatted with @lumjjb and...

OHMAN On 12/09/19 12:00 -0700, jonjohnsonjr wrote: >This way, if I want to add zstd support, I can just check: >```go >if mt.Compression == "zstd" {} >``` I agree that...

i will not be able to make the call, but I feel the discussion is on the right track. I do like the way Jon laid out an interface for...

I suppose this is fine. Any assumptions on providing that mapping would be left to the runtime implementation, so the MUST here makes sense. LGTM [![Approved with PullApprove](https://img.shields.io/badge/runtime--spec-approved-brightgreen.svg)](https://pullapprove.com/opencontainers/runtime-spec/pull-request/939/?utm_source=github-pr&utm_medium=comment-badge&utm_campaign=opencontainers/runtime-spec)

_house keeping:_ hrm. This is another conditional `MUST`, but it is a behavior I think is consistent with how runc and pals currently does. So rev'ing the spec version ought...

oh no. This is no good. How was the default gid `0`?! So: A) if there is a uid:gid provided in the config, then the runtime overrides just the uid,...

let's make a decision on whether this is required for v1.0.0

_house keeping:_ is this still an interested topic?