Barry Pollard
Barry Pollard
No, LCP is measured as a separate audit before this one.
@rviscomi wasn't happy moving from this: ```sql JOIN ( SELECT _TABLE_SUFFIX AS client, COUNT(0) AS total FROM `httparchive.summary_pages.2022_06_01_*` GROUP BY _TABLE_SUFFIX) ``` to this style which v2 and above insists...
Yeah the layout code is complex (which is why I haven't gone and fixed it myself!). I think we need to add `line_position` support to `[sqlfluff:layout:type:end_bracket]` config. But to be...
OK then I think we might be OK then as think that _was_ made optional. Let me try and run fix and see what it looks like.
@rviscomi can you spot check a few files? Will be good to get this upgraded as long been on my list to resolve this issue!
> I would re-enable LT09 - Select targets on new lines. While I agree with this for top-level queries, it breaks subqueries like this: https://github.com/HTTPArchive/almanac.httparchive.org/blob/64f8794c9f8bd24de2f46e6b0a721403786430a0/sql/2019/cms/14_15.sql#L24 And IIRC we have a...
Yeah "breaks" is a bit strong. And it is a lot more readable with it enforced: ```diff FROM `httparchive.pages.2019_07_01_*` JOIN - (SELECT _TABLE_SUFFIX, COUNT(0) AS total FROM `httparchive.pages.2019_07_01_*` GROUP BY...
Actually looking over the changes with `sqlfluff fix` for this rule I'm not loving the changes to be honest. The fact it ONLY works on `SELECT` targets and not the...
Mostly we query the HTTP Archive dataset which is based on a monthly crawl of the top X million websites in the world. It gathers all the stuff that makes...
A few questions: 1. Why encoded body size instead of decoded body size? If specifically interested in encoded I think we should include that in the name. 2. Does this...