Barry Pollard
Barry Pollard
Fair enough! It seems like it's our [media uploader](https://web-dev-uploads.web.app/uploader) doesn't provide width and heights by default for videos, like it does for images. Imagine that's making it less easy to...
According [to this](https://github.com/GoogleChrome/web.dev/wiki/Imgix), this is apparently the repo: https://github.com/GoogleChromeLabs/chrome-gcs-uploader but I can't see it. Not sure if restricted, or moved?
I'm in! Thanks.
I’m keeping [my PR](https://github.com/GoogleChrome/web-vitals-extension/pull/177) updated with the latest v4 branch as we merge stuff. Well actually I’ve gone ahead of that now since I have the redirect stuff in there...
We definitely do use an 8ms threshold: https://github.com/GoogleChrome/web-vitals/blob/5420b5f4b28ad9296ca64e53858a8f93a74f7443/src/attribution/onINP.ts#L98-L102 We do use the LoAF end time to clap the processing time: https://github.com/GoogleChrome/web-vitals/blob/5420b5f4b28ad9296ca64e53858a8f93a74f7443/src/attribution/onINP.ts#L217-L225 But given Event timing is only accurate to 8ms,...
> But since you don't always have LoAF I think web-vitals.js tried to cluster by event-timing data only and then use loaf only for attribution? Correct. Currently we just use...
Hi @Mattstir , we're not looking to add this functionality to this library at this time for the reasons explained here: https://github.com/GoogleChrome/web-vitals/pull/433#issuecomment-1961430051 > However, while we appreciate the potential usefulness...
Raised a bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1894695
So #476 resolved a lot of the cases for now but this one is still susceptible to failing intermittently due to the Firefox slowness in GitHub Actions: https://github.com/GoogleChrome/web-vitals/blob/fd8b0c3a59089c080fdb3ed9297a9e73867f4963/test/e2e/onLCP-test.js#L715-L718 A rerun...
Either way leaving this open to remind us to remove those workarounds once the real fix is released.