Barry Pollard
Barry Pollard
I'm concerned about all the nuances we might need here. For native lazy-loading images that's probably fairly obvious and OK. For JS lazy-loading that takes more logic. And for delayed...
> did earlier versions of the API only support one script element, perhaps? Yes that's correct. It's a relatively recent change (Chrome 107 I think) that allowed multiple prerenders.
Yeah there's current a limit of 10 prerenders. IMHO that is more than enough, and prerendering even that many (which I could easily see happening if prerendering all in-viewport links)...
Can confirm manually applying https://github.com/herveh35/Piwik-IntranetGeoIP/commit/ae9b535961b096796bb208b0e9190cf268cdd568 allowed me to activate the plugin and it seems to be working fine under 4.2.1.
Anyone any idea why CI is failing?
@jakearchibald would you add a default `--var-width: 16; --var-height: 9;` when you add that new CSS rule, so that it defaults to the current `16/9` rather than `0/0` if width...
OK so this is what I think it needs, added to next.scss Add `--var-width`, `--var-height`, and `aspect-ratio`: ```css /// Video related elements video, .youtube { --var-width: 16; --var-height: 9; position:...
Not sure what you mean? The current CSS for web.dev has 16/9: https://github.com/GoogleChrome/web.dev/blob/076e60738ad7c89c2f733db48c7c7c7221100784/src/scss/next.scss#L699 ```css /// Video related elements video, .youtube { position: relative; aspect-ratio: 16/9; } ``` So if you're...
The alternative is to go with the simpler `ratio` @argyleink [suggested above](https://github.com/GoogleChrome/webdev-infra/issues/28#issuecomment-1093062546). Then could just set `style="aspect-ratio: ${ratio}"` on the element and wouldn't need to change any of the above....
> The reason I went for width and height is it means we can remove the workaround when https://github.com/w3c/csswg-drafts/issues/7524 is fixed. Well that still depends on use changing our use...