Tomás Chor

Results 266 comments of Tomás Chor

This is the issue that described what I was seeing: https://github.com/CliMA/Oceananigans.jl/issues/3290 @johnryantaylor does that looks like what you're seeing? If so, the two workarounds that I have come up with...

> > This is the issue that described what I was seeing: #3290 > > @johnryantaylor does that looks like what you're seeing? > > If so, the two workarounds...

Thanks for running these tests, @glwagner. They really do look like the issue in https://github.com/CliMA/Oceananigans.jl/issues/3290 > The easiest fix is to eliminate the pressure separation. Since we're waiting for the...

> `2)` is because I cannot think of a situation where you would want to output something different than Array? But please correct me if I'm wrong. I haven't found...

@simone-silvestri the issue which this was meant to close is now closed. (See https://github.com/CliMA/Oceananigans.jl/issues/3137#issuecomment-1912426216) Should we close this PR as well?

> Does that PR also handle distributed grids? That issue had nothing to do with anything distributed. So if this fixes some issue with distributed grid then maybe it should...

Docs are previewing here: https://clima.github.io/OceananigansDocumentation/previews/PR3080/ I checked all the examples with `NonhdyrostaticModel` and they all look the same as they do on the `stable` branch. Furthermore, the few tests failures...

With this last commit both the hydrostatic and nonhydrostatic models are working locally for me and they only have a `model.pressure` field; no more `NamedTuple`s of pressure. But let's see...

I think code-wise, this is pretty much ready (save some occasional polishing like [here](https://github.com/CliMA/Oceananigans.jl/pull/3080#discussion_r1192737129)). `pHY` and `pNHS` are no more, and both both hydrostatic and nonhydrostaic models, the pressure is...

> What is the difference in the regression tests between `main` and this PR? afaik nothing. I think the change in the pressure algorithm causes very small differences in the...