Tom Akehurst

Results 242 comments of Tom Akehurst

It's a change I'd definitely like to make, but reviewing a 31 file PR requires a level of uninterrupted focus I'm not not getting much of at the moment. Also...

@dirkbolte as we discussed last week

I've wondered about that, then wondered if it's overkill. Not sure how likely it is that collisions will occur, but maybe I'm lacking imagination...

OK, agree playing it safe might be a good idea. How about just `--ext..=` so it's not quite as many keystrokes?

@dirkbolte as we discussed last week

I think I have an idea how to do this with what is effectively a bit of syntactic sugar over the existing stub event listener interface. We could create a...

I think we could possibly simplify this in most cases by defining a generic value class for this, something like: ```java public class ParameterisedExtensionDefinition { private final String name; private...

Can you add a couple of acceptance tests? One happy path and one where the ID isn't found at a minimum would be good.

Still a couple of outstanding comments to address: 1. Returning the deleted stub 2. Asserting that no exception is thrown when deleting a non-existent stub Looking good other than that.

Hey @burcuakkayaa I think we're very close on this one. If you've got some capacity to look at the last couple of comments, then I'll be happy to merge this.