Tom Akehurst

Results 242 comments of Tom Akehurst

This is looking good so far but let's add add a test that checks the name is actually emitted in logs. Also, what might be interesting is to also have...

Looking good so far @kapishmalik, a few observations: * Would be good to see some negative tests. I suspect there are some cases that'll make this code blow up e.g....

The main issue with just enabling this behaviour without a config flag is that it'll be a breaking change for anyone who depends on the current behaviour. I think we...

What if we did the splitting in the `Request` implementation, rather than in the matching/templating system? We could extend `QueryParameter` so that it explicitly modelled these cases. Then if the...

I'm not 100% clear on the intent/use case for this. Is it essentially that if your app under test uses `HttpsUrlConnection` when talking to mock APIs, that it'll accept WireMock's...

WireMock doesn't currently support this, and I suspect what constitutes "overlapping" might vary depending on the context. Some specific examples might help illuminate the issue.

I broadly agree with your proposed approach, but I think a multi-release JAR might not be such a great idea as it's the Jetty version rather than Java that we're...

I suggest we keep all sources under `src/main/java` and have `jetty11` and `jetty12` packages rather than having separate source trees for different Java versions. It should be fine to have...

Yeah, I guess that could be tricky. I wonder if we could put the compatibility tests in a sub-project that has Jetty 12 as its dependency, and keep Jetty 11...

The Gradle team only seems to support multi-release very reluctantly. And I really think we shouldn't be switching it on the Java version.