Tobias Queck

Results 52 comments of Tobias Queck

> I am still unsure about the `transportcheck-service`. The existing functionality looks so similar to your new functionality that I think we need to consolidate both. @longieirl & @GDamyanov please...

@GDamyanov `/sap/bc/adt/cts/transportchecks` already exists at https://github.com/SAP/open-ux-tools/blob/main/packages/axios-extension/src/abap/adt-catalog/services/transportcheck-service.ts. For `/sap/bc/adt/filestore/ui5-bsp/ui5-rt-version` please make sure to align the service with the other adt service we already have e.g. do not hard code the path,...

@petermuessig if you set `directLoad: true` then the `@sap/ux-ui5-tooling` doesn't proxy requests to UI5 sources but intercepts html files and replaces paths like `/resources/sap-ui-core.js` with a full domain e.g. `https://ui5.sap.com/1.120.0/resources/sap-ui-core.js`....

> We are currently reworking the test started code. Till then, I would prefer not to integrate the `preview-middleware` into the "basic" templates of UI5 applications. > > Let's keep...

@cfg74 could you please plan to get this one fixed.

> @tobiasqueck do you want to follow-up on this one? Still seems like a reasonable adjustment to me. I would be happy if someone takes it from here, I won't...

> Otherwise, it does not work properly and produces correct changes with the reference to the app variant. Currently, the changes done by CPE have the reference pointing to the...

@korotkovao. I looked at your PR #2134 again and the implementation feels wrong - not incorrect but just not the way it should be. So, I thought about it a...

@marianfoo please check `generatePreviewFiles ` in https://github.com/SAP/open-ux-tools/pull/2062. This might actually be what you need. We are adding these two new functions so that a user can "eject" a virtual file...

Ok, I get the problem now. I still like the feature. Let me get #2062 in first, and then think about this one as soon as time permits. We already...