open-ux-tools
open-ux-tools copied to clipboard
FEATURE - Extend axios-extension services apis
As a developer, I want to I want to consume all requests to ABAP system during Adp Project creation via axios-extension, so that I I don't have to deal with the connection to ABAP system
Description
Currently during creation of Adp Project several calls are made to ABAP system:
- /sap/bc/ui2/app_index/ui5_app_mani_first_supported
- /sap/bc/adt/filestore/ui5-bsp/ui5-rt-version
- /sap/bc/lrep/dta_folder/system_info
These endpoints should be added to the appropriate services in axios-extension
Technical Design
"@sap-ux/axios-extension" module should be enhanced
Acceptance Criteria
GivenWhenThen format (https://martinfowler.com/bliki/GivenWhenThen.html)
Given I have an adaptation project when I generate it then all requests to ABAP system during generation should be made with axios-extension.
Notes
Tasks
- [ ]
- [ ] Unit Tests added
- [ ] Test Cases defined
@GDamyanov /sap/bc/adt/cts/transportchecks already exists at https://github.com/SAP/open-ux-tools/blob/main/packages/axios-extension/src/abap/adt-catalog/services/transportcheck-service.ts.
For /sap/bc/adt/filestore/ui5-bsp/ui5-rt-version please make sure to align the service with the other adt service we already have e.g. do not hard code the path, but use the discovery service to get it at runtime.
@GDamyanov
/sap/bc/adt/cts/transportchecksalready exists at https://github.com/SAP/open-ux-tools/blob/main/packages/axios-extension/src/abap/adt-catalog/services/transportcheck-service.ts.For
/sap/bc/adt/filestore/ui5-bsp/ui5-rt-versionplease make sure to align the service with the other adt service we already have e.g. do not hard code the path, but use the discovery service to get it at runtime.
@tobiasqueck we won't need this endpoint anymore sap/bc/adt/cts/transportchecks