BUG - Incorrect definition of fiori-tools-proxy in ui5.yaml of Adaptation Projects

[nikmace]

Description

fiori-tools-proxy afterMiddleware should have fiori-tools-preview middleware. Otherwise, it does not work properly and produces correct changes with the reference to the app variant. Currently, the changes done by CPE have the reference pointing to the base app ID instead of the app variant name.

Steps to Reproduce

Steps to reproduce the behavior:

1. Generate an ADP project with the Adaptation Project writer
2. Open CPE and make propertyChanges for example
3. Open the saved change file and see incorrect reference

Expected results

Reference points to app variant name

Actual results

Reference in the change points to base app id

Screenshots

Correct definition of ui5.yaml proxy middleware should be:

Version/Components/Environment

Add any other context about the problem here OS:

• [ ] Mac OS
• [ ] Windows
• [ ] Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

[tobiasqueck]

Otherwise, it does not work properly and produces correct changes with the reference to the app variant. Currently, the changes done by CPE have the reference pointing to the base app ID instead of the app variant name

I'd like to understand how the order of the middlewares affect that value.