open-ux-tools icon indicating copy to clipboard operation
open-ux-tools copied to clipboard

feat: Extend axios-extension services

Open GDamyanov opened this issue 1 year ago • 3 comments

Feat for #1957

  • Extend axios-extension services

GDamyanov avatar May 23 '24 13:05 GDamyanov

🦋 Changeset detected

Latest commit: 4e4d81084cfebaabbefe45658084d132587654f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@sap-ux/axios-extension Patch
@sap-ux/adp-tooling Patch
@sap-ux/app-config-writer Patch
@sap-ux/backend-proxy-middleware Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/system-access Patch
@sap-ux/odata-cli Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/create Patch
@sap-ux/cap-config-writer Patch
@sap-ux/abap-deploy-config-writer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 23 '24 13:05 changeset-bot[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 31 '24 06:05 sonarqubecloud[bot]

I am still unsure about the transportcheck-service. The existing functionality looks so similar to your new functionality that I think we need to consolidate both.

@longieirl & @GDamyanov please work together on consolidating this functionality. I did a bit of testing and noticed that the parameter package is not required for the existing check for apps, if you remove it, it becomes even clearer that the implementations need to be consolidated. You can use https://github.com/SAP/open-ux-tools/compare/feat/1957/extend-axios-extension...feat/1957/extend-axios-extension-proposal?expand=1 as a starting point.

@longieirl that would be a breaking change for the existing function, but I am ok with it since we have a 0.x version and it simplifies the API for future usage

Afterwards, please consolidate the parsing. The existing one (for apps) has an additional feature of also listing available & valid transport requests if the object is not yet locked on a request. @GDamyanov I am pretty sure that is also valuable for adaptation projects. @longieirl the new functionality (for ADP) also returns the package name which is useful if the consumer then offers creating a new transport afterwards since it is required for new transports and must match the existing one. Therefore, please, bring both functionality into one instead of having two separate half-complete implementations.

tobiasqueck avatar May 31 '24 09:05 tobiasqueck