Tim Fish

Results 384 comments of Tim Fish
trafficstars

Marking `@node-rs/helper` as external means that it and anything it loads will not be bundled, so as a minimum you'd need to ship `node_nodules/@node-rs/*`. This works because `ncc` supports statically...

This works: ```js try { // trick bundler into locating and including all required .node binary assets const num = Math.random(); require(require.resolve(`@node-rs/crc32-${num}.node`)); } catch (_) {} const crc = require("@node-rs/crc32");...

If modify `@node-rs/crc32/index.js` to this, it bundles and runs correctly ```js const { loadBinding } = require('@node-rs/helper') // This will never be called at runtime but bundlers will copy any...

It doesn't work from `@node-rs/helper` because it can't statically analyse `packageName`.

This is the simplest I've managed to get it: ```js if (!process) { require(require.resolve(`@node-rs/crc32-${process}.node`)); } ``` Another option would be to drop the use of `@node-rs/helper`, `@napi-rs/triples` and generate a...

The thorn in the side of anyone publishing and maintaining a native node module is Electron. Most Electron devs seem to be using webpack to keep `node_modules` out of their...

It's also possible to [write flutter plugins in Rust](https://medium.com/flutter-community/finally-running-rust-natively-on-a-flutter-plugin-here-is-how-6f2826eb1735) and I assume you could then use that on both desktop and mobile. I've realised that it's even simpler than the...

Waiting on this being added upstream https://github.com/getsentry/sentry-javascript/pull/5512

Now most of the context has moved to `@sentry/node`, I just need to work out how to bring those changes into the Electron SDK without making it a breaking change!

Is removing the existing `event.contexts.device.language` considered a breaking change?