Tim Fish

Results 397 comments of Tim Fish

Still not sure what is the best approach. Runtime and meta-info both have the minor downside of slightly more code in the bundle although I doubt it will be that...

This may have been fixed by the latest stack parsing fixes. Can someone get me the frames from the event to check?

I've been looking into this more and I'm working on a fix for the above mentioned issue with `electron-rebuild` where it fails to pass the correct parameters to `prebuild-install`. However,...

`electron-rebuild` is often used to compile binaries for different architectures to the current one so you can't rely on the existing binaries being good. For example most devs will be...

My total build assets come to under 3MB so I'm going to try shipping all assets in a single package and copy to `{package_name}.node` from the install script. This also...

I've got everything in one package and copying across in an install script but this doesn't actually fix the issue with Electron. It appears that the reason this all "just...

That might work but with my workaround for #316, webpack will pickup all the .node files and include them in the output. If I don't bundle, node_modules will have have...

My currently workaround is: `install.js` called on `install` ```js const { copyFileSync, existsSync } = require('fs'); const { platform, arch } = require('os'); const { platformArchTriples } = require('@napi-rs/triples'); const...

> There is no need to force it, just change the default value. Changing the default naming convention would be a breaking change. ie. you'd need to release napi v3

Maybe add it as a flag on `build`? ```json "scripts": { "postinstall": "napi build --release --skip-if-binary-found", } ```