Tim Fish

Results 393 comments of Tim Fish
trafficstars

The async OS evaluation needs to handle reentrancy properly. If a second events occurs before the async task has completed, `_cachedContexts` will be defined but not fully populated. `_cachedContexts` should...

Now only the dynamic properties are calculated on every event and everything else is cached. We don't call `_getContexts()` from the constructor because on some platforms this will cause it...

I'm still getting what looks like leakage between tests. When I run them locally they all pass on first run and then failures on the next run. Test failures vary...

I've been away for a few days but will get back onto this on Monday!

Tests are all passing 🎉🎉🎉🎉🎉 Thanks @onurtemizkan for all your hard work fixing this for me! I see there are some new methods for fetching single events. Is it a...

All done! I also replaced `getMultipleEnvelopeRequest` with `getEnvelopeRequest` where appropriate.

I'm going to submit a PR to change everything to `?`...

This could potentially be a breaking change since customers might be using `RewriteFrames` and expecting some specific anonymous frames? Seems highly unlikely anyone is doing this but worth considering.

On the subject of monkey patching `Promise`... How about optionally recording stack traces as they pass through promises to work around ["zero-cost async stack traces"](https://cloudreports.net/v8-zero-cost-async-stack-traces/)? The number of times I've...