sentry-electron icon indicating copy to clipboard operation
sentry-electron copied to clipboard

Published 20 hours ago • verified publisher icon getsentry

Add support for Culture Context

Open AbhiPrasad opened this issue 3 years ago • 7 comments

https://develop.sentry.dev/sdk/event-payloads/contexts/#culture-context

The language field in device context was deprecated,

AbhiPrasad avatar Jul 29 '22 20:07 AbhiPrasad

Waiting on this being added upstream https://github.com/getsentry/sentry-javascript/pull/5512

timfish avatar Aug 02 '22 14:08 timfish

upstream changes will be published as part of https://github.com/getsentry/publish/issues/1327

AbhiPrasad avatar Aug 31 '22 17:08 AbhiPrasad

Released in 7.12.0 - https://github.com/getsentry/sentry-javascript/releases/tag/7.12.0

AbhiPrasad avatar Aug 31 '22 17:08 AbhiPrasad

Now most of the context has moved to @sentry/node, I just need to work out how to bring those changes into the Electron SDK without making it a breaking change!

timfish avatar Aug 31 '22 18:08 timfish

Is removing the existing event.contexts.device.language considered a breaking change?

timfish avatar Sep 11 '22 00:09 timfish

I'm tempted to leave this until the next major version bump since adding this now would simply involve copying code from @sentry/node and deleting it for v5.

timfish avatar Oct 14 '22 10:10 timfish

Is removing the existing event.contexts.device.language considered a breaking change?

This is not indexed by Sentry, so I don't think it is.

I'm tempted to leave this until the next major version bump since adding this now would simply involve copying code from @sentry/node and deleting it for v5.

Yeah I think that's fine, we can leave it for the next major bump

AbhiPrasad avatar Oct 14 '22 13:10 AbhiPrasad