Tim Fish

Results 402 comments of Tim Fish

I just tested your sentry-bug-repro example with 7.16.0 and since https://github.com/getsentry/sentry-javascript/pull/5627, `next` is no longer called and because the domain `error` is no longer handled, the process terminates. The output...

@AbhiPrasad can probably confirm, but I think this is blocked on `async_hooks` support (https://github.com/getsentry/sentry-javascript/issues/3660).

It's happening in some third-party middleware. I suppose I can try and wrap our call to `next()` in the domain. Let me try that....

> I suppose I can try and wrap our call to `next()` in the domain. Let me try that.... There is no way to do this unfortunately since `next` is...

I've just tested it and the `ERR_HTTP_HEADERS_SENT` error is actually caused by the call to `res.send("FAIL")`. Due to the async nature of the error and the fact that you've already...

I'm tempted to leave this until the next major version bump since adding this now would simply involve copying code from `@sentry/node` and deleting it for v5.

> `crashed_process` is `browser` so I think the error happened in the renderer Unintuitively, `browser` is the Electron main process and `renderer` is the browser renderer process. These are the...

More details of the scope propagation issues are documented [here](https://develop.sentry.dev/sdk/research/performance/#scope-propagation).

That would work but I guess we'd need to split `@sentry/tracing` into browser/node first. When you bundle the dependencies, users can no longer install more than one Sentry package. We'd...

For the backend, we've recently added [`runWithAsyncContext`](https://docs.sentry.io/platforms/node/guides/connect/configuration/async-context/) to `@sentry/node` which gives full scope isolation across async contexts via `AsyncLocalStorage` in Node >= v14. While the primary use case for this...