Tim Fish

Results 399 comments of Tim Fish

The Windows test failures show that Electron notifies us of the renderer crash but no minidump was found: ``` [App] [ Main] Sentry Logger [log]: 'renderer' process 'crashed' [App] [...

I added some crude retrying and it appears there just isn't a minidump generated for abort on Windows: ``` [App] [ Main] Sentry Logger [log]: 'renderer' process 'crashed' [App] [...

> is that something that is just a limitation for electron? The [docs for `sadness_generator::raise_abort`](https://docs.rs/sadness-generator/0.5.0/sadness_generator/enum.SadnessFlavor.html#variant.Abort) say: > Note that on Windows, [std::process::abort](https://doc.rust-lang.org/nightly/std/process/fn.abort.html), the canonical way to abort processes in Rust,...

Yes, [confirmed](https://github.com/getsentry/sentry-electron/actions/runs/3875789883/jobs/6608825947#step:6:505) that the Electron `crashReporter` does not send a minidump on Windows due to `sadness_generator::raise_abort()`. I want to double check C `abort()` to ensure it's not something specific to...

With the following basic Node-API module I get minidumps on macOS and Linux but nothing on Windows. That suggest this is an upstream issue with Electron. ```c++ #include #include namespace...

Just merged from master to see if this has been fixed in any of the recent versions of Electron...

Currently there is no scope synchronization to the ANR process which includes user/tags/extra. I've opened an issue to track this work in the JavaScript repository since that is where this...

The next v7 release will fix this but you should use the `anrIntegration` as `enableMainProcessAnrDetection` has been deprecated: ```ts Sentry.init({ dsn: '__DSN__', integrations: [Sentry.anrIntegration|({captureStackTrace: true})] }); ```

This was fixed a few releases ago. It's worth noting that if the event loop remains blocked for more than 5 seconds after ANR is detected, we give up fetching...

Thanks for the detailed report. I guess we might need to disable ANR between suspend and resume events from the [powerMonitor](https://www.electronjs.org/docs/latest/api/power-monitor) module.