Tim Fish

This now passes `[event, hint]` serialised from render to main and adds a test that ensures that `hint.attachments` added in the renderer `beforeSend` are submitted in envelopes from the main....

> `beforeSend` explicitly is meant to run after the event processors If `EventToMain` is the last integration, will this not be true?

> not sure if we can make this change. Currently, `beforeSend` is not called at all in the renderer process so it's currently not possible to do anything before an...

That looks like an interesting stack trace and I'd like to get the bottom of what's happening but I'll need a way to reproduce it locally. Do you have a...

Since I've not heard back I'll close this issue for now but please do re-open this if you have any more information to help me track it down.

Just to clarify and make sure I've understood correctly... An optional `shouldAttachTracingHeadersToRequest` function gets added to `RequestInstrumentationOptions` and if users supply this function, `tracingOrigins` should be ignored and `shouldAttachTracingHeadersToRequest` becomes...

> so that it's hopefully clearer and so it reflects the new goals of this project Wow, thanks. That's a pretty comprehensive summary!

> Default to always creating a span, regardless of tracingOrigins, unless shouldCreateSpanForRequest is defined and returns Is this considered a non-breaking change since it fixes broken behaviour? Rather than edit...

> I think it's nice to be able to see right up top what's been done and hasn't Ohhh yes, much better at the top! I think since I'm not...

For node.js: > - Ensure both options are documented > - In v8, consider moving both options into the Http integration I was just about to document these additions. How...