stuartmorgan-g

Results 1161 comments of stuartmorgan-g
trafficstars

Supporting two preference stores is a lot more complicated than just allowing control of the store name unfortunately.

Can you explain at a high level what your use case is here? I.e., what is the change in behavior, in terms of user experience, that you are trying to...

It sounds like we'll probably need to update the add-to-app documentation to provide guidance here; presumably the application project is going to need to sign plugin builds that are on...

Please don't ping people like that. We have a triage process, and this issue isn't an emergency that needs to bypass it.

No, this is unrelated to 43785; `shared_preferences` doesn't have any instance-based channels. Given that this is only affecting release Android builds, it feels like an R8 issue. It may be...

> I created a new issue in that package. Packages using `shared_preferences` do not need to do anything different than they were doing before. > In my case I can...

@GiacomoPignoni Are you still planning on updating this PR per the review feedback above?

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate...

We should comment this out with an explanation, as with most other lints we don't use use (see the rest of the file), rather than removing it. It's unfortunate that...

> I'll convert to draft for a bit. If we are waiting for the new formatter first, this will need to be Draft until all of our packages require Dart...