packages
packages copied to clipboard
flutter
Remove `no_adjacent_strings_in_list` from enabled lint rules.
no_adjacent_strings_in_list conflicts with another rule, prefer_adjacent_string_concatenation. I suggest removing the former.
See https://github.com/dart-lang/sdk/issues/59041
prefer_adjacent_string_concatenation is a style-oriented rule, but it is in the package:lints recommended set. So... it is recommended.
no_adjacent_strings_in_list is an error-preventing lint rule, but it's usefulness is waning, as the new style of the Dart formatter will always split adjacent strings into new lines.
We are marking these two lint rules as incompatible. If the fix in this PR is not desired, there are two other options:
- Remove
prefer_adjacent_string_concatenationfrom the enabled lint rules. - Insert an
# ignore:comment in the top-level analysis options file, and an# ignore: included_file_warningcomment in any files that include the top-level one.
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the CLA.
- [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I linked to at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes. - [x] I updated/added relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or this PR is test-exempt.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
We should comment this out with an explanation, as with most other lints we don't use use (see the rest of the file), rather than removing it.
It's unfortunate that we're having to turn off a useful warning before we get the formatter change that would make the mistake the warning would catch obvious though.
I'll convert to draft for a bit.
If we are waiting for the new formatter first, this will need to be Draft until all of our packages require Dart 3.7, right?
(triage): Talked to @srawlins and he says this is still on his radar.
Howdy, checking in from triage again. @srawlins is this still on your radar?
Waiting for minimum package versions to be >= 3.7.0.
Is this condition now satisfied? :)
Nope, the first package I checked is still 3.6.0. https://github.com/flutter/packages/blob/main/packages/animations/pubspec.yaml
The only automatic roll-forward of min SDK versions is that after each stable we update any package that supports a version of Flutter/Dart older than the N-2 stable Flutter version to require N-2 (since we don't run analysis in CI of anything older than N-2, so wouldn't find breakage).
So in the normal course of business, this would be landable after the next Flutter stable release. If there's a strong desire to land this before then, it would be fine to mass-update everything to require N-1 right now, as there's no requirement to support anything older than current stable.
Everything in the repo is now using the new formatter (except for the repo tooling, but that's fine), so we can land this now.
We should comment this out with an explanation, as with most other lints we don't use use (see the rest of the file), rather than removing it.
This still needs to be addressed, then this can land.