stuartmorgan-g

Results 1177 comments of stuartmorgan-g
trafficstars

> The problem with unbundling the `material` library is that `flutter create` has to create a template that uses a widget library of some sort [...] We could depend on...

(CI will make me split out the platform interface change, but I wanted to start with a combo PR to provide the whole picture.)

> Although you can set a `Timer` in Dart, its not really possible to get a video of an exact length by using it. Mostly because starting and stopping a...

From triage: @ruicraveiro is this still something you are planning to come back to?

> I would prefer to get it approved as it is The current version conflates `Exception`s and `Error`s as discussed in the long comment thread above, so it would not...

> I think next week I'll find enough time to finish this off. Sorry I was not able to respond before then; I was out of office for several weeks...

> I have some broken tests, but I don't think they're related to anything I did, except merging the main branch onto this one. On my machine, all Dart unit...

> I tested this PR on Android, and it worked fine; the crop indicates stabilization is being applied. > > I’m just unsure about the differences among VideoStabilizationMode levels 1,...

If impeller is breaking texture support on macOS, that would be an impeller bug rather than a `video_player` issue.

Quick note to say I haven't forgotten about this, I just haven't had time to fully context switch to give this the attention it will need. I'll try to do...