Steven Harman

Results 96 comments of Steven Harman

What would a failure case look like? i.e., how do I reproduce the issue?

Hmm. We use a `logfmt/tagged_logger` as our `Rails.logger`, and we have a piece of middleware that tags the current requests's "code owner," but we're not seeing this behavior. The middleware:...

OK, I've finally had a chance to dig into this and it looks like the [extra tags are being added by the `ActionDispatch::DebugExceptions` middleware](https://github.com/rails/rails/blob/4c30ca5934a69a7de28887bbad3f43799d1cb6ac/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb#L148-L157) - which is only present in...

One thing I dislike about `undef` is `#tags_text` is a private method of the `ActiveSupport::TaggedLogging::Formatter`. So if that API ever changes, and they remove that method, the `undef` is going...

Hmm, the more I think about it, I worry that `undef`-ing (or `undef_method`-ing) might be more trouble than it's worth. I say that b/c it will undefined the method on...

That PR was merged in April 2022. But the Rails `7-0-stable` branch was cut around December 2021 (Rails 7.0.0 was released on 2021-12-15). Meaning that PR will land in the...

We'll wait to merge this PR until we're ready to drop support for Rails < 7.1 - which isn't going to be any time too soon. 😄

@johnnyshields Assuming you've got nginx configured with `proxy_buffering on`, then you're probably fine. Similar if you're on Heroku as the Heroku Router will buffer up to 1MiB of response for...

@davidrothera Same - I'm on the latest Yubiswitch (`0.16`) on both of My M1 MacBook Pros. Running macOS 13.5 and now 13.6. I don't need anything in Input Monitoring, but...