logfmt-ruby icon indicating copy to clipboard operation
logfmt-ruby copied to clipboard

Published 20 hours ago • verified publisher icon cyberdelia

Simplify formatter handling in TaggedLogger

Open soulcutter opened this issue 2 years ago • 4 comments

Given https://github.com/rails/rails/pull/44942 was merged over a year ago, the extra handling of the formatter should no longer be necessary.

soulcutter avatar Sep 12 '23 03:09 soulcutter

Paging @stevenharman

cyberdelia avatar Sep 12 '23 04:09 cyberdelia

So, upon more investigation I can find no evidence that the merged PR mentioned in the description ever made it into a Rails release. Checking the latest: https://github.com/rails/rails/blob/v7.0.8/activesupport/lib/active_support/logger.rb

So, uh.. this is still necessary. Wow. I do not understand how the rails development process works.

soulcutter avatar Sep 12 '23 20:09 soulcutter

That PR was merged in April 2022. But the Rails 7-0-stable branch was cut around December 2021 (Rails 7.0.0 was released on 2021-12-15). Meaning that PR will land in the next Rails release, Rails 7.1. As it happens, Rails 7.1.0.beta1 was released just a few hours ago. The change is in that release.

This has been an unusually long 7.0 → 7.1 cycle, so that's probably making it seem even more confusing. Anyhow, good sleuthing! This means we can adjust our Rails dependency to >= 7.1, once it's released. 😉

stevenharman avatar Sep 13 '23 02:09 stevenharman

We'll wait to merge this PR until we're ready to drop support for Rails < 7.1 - which isn't going to be any time too soon. 😄

stevenharman avatar Oct 12 '23 21:10 stevenharman