Steven Harman

Results 96 comments of Steven Harman

> b) aliases disconnect to close, since that is the name of the methods on the underlying ruby classes. I find the mix of `close` and `disconnect` confusing. Should we...

@kbrock Can you mention the breaking changes in the Changelog? And feel free to add your own contributions to the list as well! :)

Hello, Unfortunately I'm not actively using Grocer in any current projects, and haven't had time to keep on top of it. So I'd not be surprised if something changed on...

We are unlikely to accept any pull requests without accompanying specs. Also, please try to adhere to the code style of this project - that is, we don't use the...

Hi @kbrock, Aside from the stylistic issues, and the `Rails.logger` calls there are also zero specs for this change. There also seems to be a good bit of unused code,...

@yjukaku You are quite correct. We have added a wrapper for feedback errors (see #51), but it's not been documented. I'd be happy to accept such documentation and enhancements to...

> Is this a problem in Grocer or do I have to look elsewhere? These are the first reports of this; I'm not aware of any outstanding/known bugs. Please do...

Thanks for all of the investigation, all. While not ideal, I'm glad you found a work around. If anyone would like, we'd certainly love to have someone investigate the root...

@varunlalan I was going to link to some Issues I've found in other Ruby gems that point to a problem with OpenSSL and or the certificiates, but no I see...

@Baril27 Nice find. FWIW, the `Backport` field on that bug says it's been back ported to Ruby 2.3, and it's apparently awaiting a back port to 2.2. So perhaps we'll...