Steven Harman

Results 96 comments of Steven Harman

Oops, I didn't mean to close this. I was reading it on my iPhone and must have accidentally clicked the wrong thing. Reopening now.

I also had to add `javascriptreact` explicitly, rather than `javascript`. Similarly, `ALEInfo` is reporting the current file type as `javascriptreact`. ```viml let g:ale_fixers = { \ '*': ['remove_trailing_lines', 'trim_whitespace'], \...

For some reason I wasn't getting notifications of activity on the project - sorry about that. How is `Grocer::Pusher#read_reply` intended to be used? Can you give a little example code?

A similar topic was brought up not too long ago in #78, but it was determined it we didn't need to expose the actual `#encoded_payload`. In your case, I can...

> I'd rather avoid using exceptions for flow control. I agree completely, which is why Grocer would expose a `#valid?` method for you to use. Internally we'd leverage exceptions, but...

@n-studio My thinking is: as part of the enhancement to `#valid?` and exposing `#errors`, we'd put the current `encoded_payload.bytesize` into the error message we give to `PayloadTooLargeError`. Does that make...

@mbillard I do still think going with `#valid` and `#errors` to be a great option for handling this, but I don't have the need for it now. However, you do...

@benrugg I'm not actively using grocer, so I can't comment than to say... please let us know what you find.

> comparing instance variables might be better than the result of to_bytes. Agreed. Since to_bytes can raise when invalid, rendering any two invalid notifications NOT equal, even if they are......

Oh wait... there is more to the state than just the payload... like the `:identifier`, `:device_token`, etc. Hmm...