Steven Weerdenburg

Great find, thanks @manfred-brands ! That should simplify the upgrade path. I'll drop the `design` label. This still feels like the sort of thing we can only do in a...

I'd welcome help if we want to make a concerted push to get this done sooner. Next two weeks will likely be a challenge for myself to make any progress

I'm leaning towards "change" myself but would be curious to hear others thoughts. It would be nice if this didn't have to wait for a major version. Though, the current...

I've moved this into "Future Planning" as it sounds like a breaking change. Adding "an" awaitable option here before then may require defining a new and separate method, such as...

Thanks @manfred-brands ! Yes, I was a few minutes too slow to clarify. 🙂 Looking up to an earlier investigation here, I _think_ I also saw some line endings changing...

@manfred-brands I'm unsure. It sounds like my own investigation here stopped before I could identify exactly where and what changed to strip these characters. I recall testing this on both...

Ok, I can reconfirm that the example repro works on nunit 3.14 and fails in 4.x: https://github.com/nunit/nunit.issues/tree/main/Issue4584 And I can confirm I think something @manfred-brands was saying earlier. The `\r`...

@OsirisTerje It looks like the test filter XML is getting passed in from the adapter already escaped. Is there any chance the adapter is escaping this? EDIT: It looks like...

This came up recently in an analyzer issue. It seems like we've been following Charlie's lead from the comment in https://github.com/nunit/nunit/issues/2019#issuecomment-276432448 and discouraging implementing the interface. We document this but...

There were two failures at the time I had to stop working on this yesterday, shown below. The second error, where two ValueTuples which should be equal but aren't reporting...