Steven Weerdenburg
Steven Weerdenburg
An idea: Would making `AssertionScope` a `ref struct` help here? It wouldn't be able to implement the `IDisposable` interface, but it could still participate in `using` statements if it were...
Thanks @manfred-brands ! Digging more into the "assertion scope lifetime" comment above (https://github.com/nunit/nunit/issues/4587#issuecomment-2226769908) it would appear that the upcoming .NET 9 Lock Scope feature mentioned further up by @jnm2 has...
> I tried to convert the AssertionScope into a ref struct, but that makes async methods impossible: @manfred-brands Right, of course, that makes perfect sense. Thanks for trying! Agreed `ref...
I like the idea of supporting compatibility and transitional upgrade paths like this when it's easy. As a framework change, is this something we would add only to 3.x where...
That works for me too, I imagine this would likely be fairly easy to maintain backwards compatibility over.
Thanks for your thorough proposal @jmartschinke I've tried reviewing the original issue to understand some of the design decisions there but I can't see a clear description why there is...
Thanks for the clear and minimal repro @patrykpiotrmarek I'm not immediately sure what the cause may be here so it could take a bit of investigation from the team. Would...
A repro for this was uploaded by @patrykpiotrmarek for investigation in https://github.com/nunit/nunit.issues/pull/3
Interesting, and fascinating. I can confirm this from within Visual Studio using the "Tests" output pane. On 3.14.0 I can see the output yet on 4.0.0, 4.0.1, and 4.1.0 I...
Hm. Ok. This seems to manifest on net8 only. I can still see the output on net48 when consuming NUnit 4.0.0 or 4.1.0