Łukasz Dywicki

Results 206 comments of Łukasz Dywicki

> Just for my understanding: Is there any limitation compared to the implementation we already have? There is, pure java comm provides just a serial port API, nrjavaserial brings rfc2217...

@kgoderis I think you may improve feature a bit by making certain features conditional. Given that purejavacomm can be default serial provider for mac, we could utilize karaf features with...

@joerg1985 I've experimented with a standalone parser for thing syntax and got some results. My goal was literally bypassing whole complexity of xtext and emf. Its doable. I see you...

> The options just suppress the error in case of a failed installation and the refreshing of the bundles after each installation (instead the code I posted above refreshes the...

I've updated PR as there are some troubles with amount of changes I introduced. We're clearing issues out in forum topic mentioned earlier.

@lolodomo I've updated branch, however not tested it yet as I have no 3.4.0 deployment with sma available. Lets see if others can confirm it working.

@lolodomo I've fixed troubles you pointed out, other issues you reported I leave for further discussion.

Note - this PR is a breaking change as it introduces a required parameter to thing (serialNumber).

There were some notes on it in related forum thread. Beyond these code worked fine (when I had access to SMA equipment) and filtered out wrong packet kinds.

I've updated PR to latest main, please re-review it as it solves two major troubles for users and one which affects quality of data delivered by energy meter. This PR...