Łukasz Dywicki
Łukasz Dywicki
> @splatch this PR has both awaiting feedback and WIP label, are they still valid or should a maintainer look at it? I haven't added any of these labels, thus...
@lsiepel I've updated copyright headers, i18n definitions and removed part of discovery service which was in question in unresolved comments from 2022. It should be good to go once CI...
@lsiepel I've reflected my view on this here: https://community.openhab.org/t/sma-energy-meter-binding-yields-unplausible-values/128180/165 To phrase it again, I'm not going to waste more time on nit picks. I can fix the socket leak, but...
@lsiepel I am not irritated, because I do not use this binding, hence I do not suffer from missed functionality. The most recent review contributed nothing (or at least very...
@lsiepel None of review checklist mention empty method bodies, sets over lists. Use of primitives over complex types is subjective matter related to nullnes, which in above case when elements...
This is due basic thing - 1.1.15 release is not an osgi bundle. You need to wrap it on your own or simply use wrap: prefix.
BTW have you thought of giving a try to jnr-ffi or JNA? I think both allow to cut JNI part with some performance sacrifices. I saw it used with dbus...
Hey Phillip, Thanks for fast answer. I am aware that bounding between socketcan and JavaCAN is present. I don't really mind it cause it gave this project a structured approach....
Our way in Apache PLC4X is really basic. I didn't fight for full support for NIO. What we did is just copying data between JavaCAN to netty pipeline via supplied...
From what I see the `jnaCan` uses also old io just to bridge payloads. I am looking forward to see epoll stuff coming but I can't commit myself to it....