Łukasz Dywicki

Results 206 comments of Łukasz Dywicki

I was able to test it and I believe it needs a second touch. Import of `javax.annotation` package should be marked as optional. Otherwise runtime environment is forced to host...

@jack-berg Looking at this again (on top of 0.16) I think there are more things to tackle within library design itself. The `SpanExporterConfiguration` introduces a lookup of a specific implementations...

Modbus spec in early days was not clear on that hence `-1` and `+1` errors are happening. Its all about how end device index registers - if it does it...

> Imagine the Jars being packaged into a .war, their names would be: For `maven-war-plugin` and also other WAR archive creators elsewhere you usually can specify artifact naming pattern. What...

While I like a lot that this topic come to concrete form I suppose that a bit better way would be proper tagging of states instead of multiplication of events....

> The PR provides the entity you propose. Only difference is it is called `HistoricState`. @altaroca roger, I missed type itself and got lost by changes in other areas. If...

1) Why you consider checking and casting for `DecimalState` as a fine operation, but checking for `TimeBoundState` as something wrong? It is a state just like others. In case if...

> Adding forecasts on the same channels probably will also have its own set of issues FYI forecasts and states could be easily filtered out through appropriate profiles. You can...

> 2\. Add a new datatype `TimeboundState` and duplicate all implementations of `State`, so that we have `TimeboundDecimalType`, `TimeboundHSBType` and so on. This is deeply wrong. Time is additional marker...

Association of item and metadata is loosely coupled so its not always 1:1 and it builds some kind of race condition especially during startup of the system when items and...