Peter Baumann

Results 98 comments of Peter Baumann
trafficstars

Could we perhaps instead concentrate on the easy / mechanical parts first, makeing this effectively > @siprbaum If you want I can close this PR and make the following changes:...

By the way, are you aware of PR #1384 and especially of commit 713ba1563aa3e29f7be7a1bddca803771ab5be1d which states > Remove support for TFS 2008 > > The check `Is2008OrOlder` calls _server.ConfigurationServer and...

Thx. Will take me 1-2 days to get to the review...

In the meantime, you mentioned you are hitting the Is2008OrOlder code path. Do you see any problems on Azure? Or is this not affected?

I tested this PR and it is a regression for me in a sense that I don't have PAT or Username/Password saved in the config file or given on the...

I tried what you initally named the *trusted* authentication with this piece of code:: ```csharp protected override TfsTeamProjectCollection GetTfsCredential(Uri uri) { VssCredentials vssCred; if (HasPAT) vssCred = new VssBasicCredential(string.Empty, PAT);...

@tcartwright Are you still interested in persuing this?

@AndradeMatheus Please discuss things for the pat branch in the PR #1384 to not mix things up

Does this still happen with newer git-tfs version, especially as it uses a newer libgit2 version?

I split out the removal of TFS 2008 into a seperate PR #1397, as I think it is a good thing to have independent on the PAT implemententation